Dsl1 2.5.0#1021
Conversation
2.4.7 Patch
|
still need:
|
jfy133
left a comment
There was a problem hiding this comment.
Needs adding of mapDamage to README list of tools but otherwise LGTM
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
|
Citation is there already given it is already used for damage rescaling! Line 249 in 631f18e |
|
Added mapDamage to Default Pipeline Steps in README. Standardised tool name to |
|
Will wait for mapdamage module to be added to multiqc, then should be ok to merge |
|
Should add a big fat warning top of the readme sayi g maximum NDC aversion of 22.10.6 |
|
Regarding the Bowtie read groups, the suggested edits would also need to be propagated to the bwa job.
|
jfy133
left a comment
There was a problem hiding this comment.
mapdamage stuff looks good, lets wait for feedback on the RG
|
TODO: |
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
|
I think that's everything! |
jfy133
left a comment
There was a problem hiding this comment.
LGTM assuming old linting working and tests pass
|
@ltcrod Please have a look at the RG information for the mappers. Let me know if anything would be better implemented differently. |
|
Linting works with nf-core v1.14. only failures are about template matching. |
Closes #1020.
Closes #1017.
Clsoes #1031.
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).