Skip to content

Fix to PR #108#109

Merged
apeltzer merged 7 commits intonf-core:devfrom
jfy133:dev
Dec 15, 2018
Merged

Fix to PR #108#109
apeltzer merged 7 commits intonf-core:devfrom
jfy133:dev

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Dec 15, 2018

Replaced html with ZIP for MultiQC

This includes:

  • multiqc rebuild, starting with fixing separating out FastQC output
  • adding some important singularity information to installation documentation
  • fixes readme typo
  • removed lonely double quotes from unmapped read file conversion
  • re-added accidentally removed software version section of multiqc config

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

Beginning rebuild of custom MultiQC configuration file.

This commit starts with separating out pre- and post-adapter removal config files.

This will require modification to nextflow channel outputs for the corresponding FastQC 
steps to include in the output html and/or zip files the suffixs: '_preAR_fastqc.html' and
'_postAR_fastqc.html' for pre- and post-adapterremoval steps accordingly.
@jfy133 jfy133 requested a review from apeltzer December 15, 2018 14:43
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :-)

@apeltzer apeltzer merged commit 57ab1c9 into nf-core:dev Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants