Fix redundant UDG flags#112
Merged
apeltzer merged 7 commits intonf-core:devfrom Dec 17, 2018
Merged
Conversation
jfy133
reviewed
Dec 17, 2018
Member
jfy133
left a comment
There was a problem hiding this comment.
What happens if --udg is set but PMD is not turned on downstream? What other tools utilise this flag?Thinking from a (novice-)user perspective, they might turn that flag on even if they don't want PMD tools.
Secondly, I would rather say --UDGnone instead of --UDGminus. I think this is clearer - at least from the terminology in our institute (i.e. none/half/full).
There is a typo which I've marked in a code comment.
jfy133
reviewed
Dec 17, 2018
jfy133
approved these changes
Dec 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #89 directly, also documenting the changes in both changelog and user documentation.
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updated