DSL2: Nf test conversion: shortDNA#1144
Conversation
|
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.2.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
Metagenomics section still needs tweaking, but the rest seems consistent. Try again on a different day to ensure no timestamps are used also. |
|
Tests are done, double check on another day required |
There was a problem hiding this comment.
ToDos:
- merge latest changes from
dev(includes new nf-core template) - Add profile tag to the test so it works with the new CI runner
- Update commands in the instructions for how to update the test in future
- Update snapshots to work with latest template (MultiQC got a version bump)
- Rename test to match new naming scheme
- exclude preseq command log from md5sum checks
…er into nf-test-conversion-shortDNA
…er into nf-test-conversion-shortDNA
|
Todo: test on another day to catch timestamps |
|
Tested one week later (forgot to commit final changes last week) - all tests passed |
Add suggestion from codeReview Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
Apply suggestion from review Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
|
TODO:
|
|
@TCLamnidis This PR should now be ready for merge :) |
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).This is the PR for Issue #1135