DSL2: MultiVCFAnalyser#1168
Conversation
DSL2 MultiVCFAnalyzer
|
|
TODOs:
|
|
I still need to successfully test this with multiple references and/or a multi-contig reference. |
jfy133
left a comment
There was a problem hiding this comment.
Only thing I think I see missing is some input validation check (nmormally in utils_nfcore_eager_pipeline) that if multivcfanalyzer == true && genotyping_tool != 'unifiedgenotyper' then the pipeline errors out and refuses to start
ilight1542
left a comment
There was a problem hiding this comment.
Overall lgtm, small adjustment to remove redundant (?) check of path existance within pipeline execution (should be done already by .json checks at pipeline initialization.
|
local test on HPC ran through fine when given enough memory and java heap space. Here's the config used: |
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com> Co-authored-by: Ian Light-Maka <86308592+ilight1542@users.noreply.github.com>
ilight1542
left a comment
There was a problem hiding this comment.
very minor adjustments to test validation and help texts
Co-authored-by: Ian Light-Maka <86308592+ilight1542@users.noreply.github.com>
This PR is a continuation of the work in #1142
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).