Skip to content

polyg param improvement#152

Merged
apeltzer merged 10 commits intonf-core:devfrom
jfy133:dev
Feb 27, 2019
Merged

polyg param improvement#152
apeltzer merged 10 commits intonf-core:devfrom
jfy133:dev

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Feb 25, 2019

This PR is a minor clarification fix, to make clearer what the current complexity filter does.

It changes --complexity_filter to --complexity_filter_poly_g, as fastP offers proper whole-read complexity filtering (which we may want to consider later).

I've already manually tested this on my own machine and it appeared to work. All I did was appended the params/channels accordingly.

(first code PR - hope it's not a dumpster fire ;))

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@jfy133 jfy133 requested a review from apeltzer February 25, 2019 20:42
@apeltzer apeltzer merged commit 71f0329 into nf-core:dev Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants