Conversation
PR release 2.0.5
Co-Authored-By: maxibor <maxibor@users.noreply.github.com>
Co-Authored-By: maxibor <maxibor@users.noreply.github.com>
Add optional merging and trimming
Polish pr
Remove if clause here
phue
reviewed
Mar 4, 2019
Co-Authored-By: apeltzer <apeltzer@users.noreply.github.com>
Co-Authored-By: apeltzer <apeltzer@users.noreply.github.com>
Co-Authored-By: apeltzer <apeltzer@users.noreply.github.com>
Fix remaining issue with circularmapper
Fix cardinality issues
Member
Author
|
I'll be cleaning up the trimming part - its possible to have a predefined command in there for SE/PE mode and get rid of some boilerplate code this way 👍 |
Member
Author
|
Unfortunately, the output handling with AdapterRemoval makes it a bit complicated to be able to accomodate all cases (PE/SE) into a single condensed version:
So I can't really combine individual steps in all cases, but rather have the same merging and quality trimming options in externalized commans that I use in all cases (which works fine 👍 ) to make the code a bit cleaner and easier to read. I guess once the tests pass, we can basically assume this is fine 👍 |
Polish usage, add changelog
This was referenced Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on @maxibor and @jfy133 s work and help and should provide the means to run:
Thereby addressing #137, #64.
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedThis might require some docs updating (open a PR against the
ar_optionalbranch here) and some more testing, as I adjusted some stuff in my PR on top of @maxibor 's.Thanks A BUNCH for helping out on this both!