Skip to content

VCF2Genome#305

Merged
jfy133 merged 8 commits intonf-core:devfrom
jfy133:VCF2Genome
Dec 5, 2019
Merged

VCF2Genome#305
jfy133 merged 8 commits intonf-core:devfrom
jfy133:VCF2Genome

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Dec 4, 2019

Adds consensus sequence generation step with VCF2Genome, to reach parity with EAGER2.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Usage Documentation in docs/usage.md is updated
  • Output Documentation in docs/output.md is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@jfy133 jfy133 added WIP Work in progress do_not_merge labels Dec 4, 2019
@jfy133 jfy133 added this to the V2.1 "Ulm" milestone Dec 4, 2019
@jfy133 jfy133 requested a review from apeltzer December 4, 2019 14:15
@jfy133 jfy133 self-assigned this Dec 4, 2019
@apeltzer
Copy link
Copy Markdown
Member

apeltzer commented Dec 4, 2019

Once this is merged here: bioconda/bioconda-recipes#19087

We can update the code basis as the CLI changed a small bit (doesn't need the . for current directory anymore. Also adds in a Version: 0.6 string in the help, which means we can update the scrape software versions.

Need to bump the environment once this is merged to get it passing here in tests too :-) Can you open a separate PR for updating once the above PR is merged @jfy133 ?

@apeltzer
Copy link
Copy Markdown
Member

apeltzer commented Dec 4, 2019

Also:


1s
##[error]Process completed with exit code 1.
Run markdownlint ${GITHUB_WORKSPACE} -c ${GITHUB_WORKSPACE}/.github/markdownlint.yml
/home/runner/work/eager/eager/docs/usage.md:728 MD018/no-missing-space-atx No space after hash on atx style heading [Context: "###`--vcf2genome_outfile`"]
/home/runner/work/eager/eager/docs/usage.md:730 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
/home/runner/work/eager/eager/docs/usage.md:732 MD018/no-missing-space-atx No space after hash on atx style heading [Context: "###`--vcf2genome_header`"]
/home/runner/work/eager/eager/docs/usage.md:736 MD018/no-missing-space-atx No space after hash on atx style heading [Context: "###`--vcf2genome_minc`"]
/home/runner/work/eager/eager/docs/usage.md:740 MD018/no-missing-space-atx No space after hash on atx style heading [Context: "###`--vcf2genome_minq`"]
/home/runner/work/eager/eager/docs/usage.md:744 MD018/no-missing-space-atx No space after hash on atx style heading [Context: "###`--vcf2genome_minfreq`"]
##[error]Process completed with exit code 1.

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Dec 4, 2019

Once this is merged here: bioconda/bioconda-recipes#19087

We can update the code basis as the CLI changed a small bit (doesn't need the . for current directory anymore. Also adds in a Version: 0.6 string in the help, which means we can update the scrape software versions.

Need to bump the environment once this is merged to get it passing here in tests too :-) Can you open a separate PR for updating once the above PR is merged @jfy133 ?

Yup will do. PR with complete VCF2Genome coming up in a few minutes (with correctd linting). Will update the MtNucRatio after in the morning when it bioconda should be merged.

@jfy133 jfy133 added enhancement New feature or request ready and removed WIP Work in progress labels Dec 5, 2019
Copy link
Copy Markdown
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jfy133 jfy133 merged commit 336340d into nf-core:dev Dec 5, 2019
@jfy133 jfy133 mentioned this pull request Dec 5, 2019
15 tasks
@jfy133 jfy133 deleted the VCF2Genome branch December 12, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants