Fixes missing BAM channel creation when trimBam is on but PMD is off#330
Merged
apeltzer merged 15 commits intonf-core:devfrom Jan 26, 2020
jfy133:fix_trimbamlogic
Merged
Fixes missing BAM channel creation when trimBam is on but PMD is off#330apeltzer merged 15 commits intonf-core:devfrom jfy133:fix_trimbamlogic
apeltzer merged 15 commits intonf-core:devfrom
jfy133:fix_trimbamlogic
Conversation
…ATK wbesite update
Member
Author
|
@apeltzer for a review! |
apeltzer
approved these changes
Jan 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bugfix adds a missing logic for creating a BAM channel for genotyping, when turning on trimbam but not pmdtools at the same time.
Otherwise, when genotyping was not requested, but trimbam was requested a missing ch_XXX_for_unifiedgenotyper error was reported,
PR checklist
Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md