Skip to content

Add social preview image#352

Merged
maxulysse merged 3 commits intonf-core:devfrom
maxulysse:dev
Feb 13, 2020
Merged

Add social preview image#352
maxulysse merged 3 commits intonf-core:devfrom
maxulysse:dev

Conversation

@maxulysse
Copy link
Copy Markdown
Member

  • Add social preview image

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse requested review from a team, apeltzer and jfy133 February 12, 2020 12:52
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Feb 13, 2020

Already had one actually, but looks like the font was a bit off versus the one you've added. Once tests pass will merge and update with the new image.

@maxulysse
Copy link
Copy Markdown
Member Author

I did not notice that there was one already, I'll check my code again and remove these files in this PR as well.

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Feb 13, 2020

The 'old' one we orginally have is under docs/images/nf-core_eager_socialmediatemplate.svg, you can remove that and I'll update with your new (I assume consistent with the rest of nf-core) one.

Ping me once ready!

@maxulysse
Copy link
Copy Markdown
Member Author

@jfy133 Files removed.
The main issue was that the image had a transparent background (which doesn't work good in nightmode).
The size of the logo and fonts was slightly off, but that was less important.

@maxulysse maxulysse merged commit 7c7f927 into nf-core:dev Feb 13, 2020
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Feb 13, 2020

Image updated in settings too 👍

@maxulysse
Copy link
Copy Markdown
Member Author

Wasn't it up to date already?

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Feb 13, 2020

Uhhh maybe? It seemed to change when I did it? But maybe that was a wierd flickering bug. All good anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants