Skip to content

Pmdtools addparams#353

Closed
jfy133 wants to merge 9 commits intonf-core:devfrom
jfy133:pmdtools-addparams
Closed

Pmdtools addparams#353
jfy133 wants to merge 9 commits intonf-core:devfrom
jfy133:pmdtools-addparams

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Feb 13, 2020

Adds additional PMDtools functionality - adding --pmdtools_first and --pmdtools_platypus, at the request of @pontussk, and some additional cleanup.

Also includes an additional pmdtools/trimbam only check to resolve #349

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@jfy133 jfy133 requested a review from apeltzer February 13, 2020 12:21
@jfy133 jfy133 self-assigned this Feb 13, 2020
@jfy133 jfy133 added the enhancement New feature or request label Feb 13, 2020
@jfy133 jfy133 linked an issue Feb 13, 2020 that may be closed by this pull request
@jfy133 jfy133 added needs upstream fix Needs a fix in the upstream tool project WIP Work in progress labels Feb 29, 2020
@apeltzer apeltzer added this to the V2.2 "Ulm" milestone Feb 29, 2020
@apeltzer
Copy link
Copy Markdown
Member

apeltzer commented Apr 9, 2020

Lets keep this for a while - wait for TSV and merge this to TSV. Then we can do the 2.2 Ulm release soon :-)

@jfy133 jfy133 modified the milestones: V2.2 "Ulm", V2.3 "Wangen" Apr 10, 2020
@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Apr 10, 2020

Actually I say we push it back to 2.3, to keep tSV lean, and as we've not recieved any more feedback yet exactly how to structure the requested parameters.

@apeltzer
Copy link
Copy Markdown
Member

Fine by me! :-)

@jfy133 jfy133 marked this pull request as draft July 15, 2020 06:25
@jfy133 jfy133 closed this Oct 20, 2020
@jfy133 jfy133 deleted the pmdtools-addparams branch October 20, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs upstream fix Needs a fix in the upstream tool project WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --platypus option to PMDtools

2 participants