Pmdtools addparams#353
Closed
jfy133 wants to merge 9 commits intonf-core:devfrom
jfy133:pmdtools-addparams
Closed
Conversation
Nextflow doesn't like double dash in run names for some reason. This would occur when a PR was from a fork not a branch.
apeltzer
approved these changes
Feb 28, 2020
Member
|
Lets keep this for a while - wait for TSV and merge this to TSV. Then we can do the 2.2 Ulm release soon :-) |
Member
Author
|
Actually I say we push it back to 2.3, to keep tSV lean, and as we've not recieved any more feedback yet exactly how to structure the requested parameters. |
Member
|
Fine by me! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds additional PMDtools functionality - adding
--pmdtools_firstand--pmdtools_platypus, at the request of @pontussk, and some additional cleanup.Also includes an additional pmdtools/trimbam only check to resolve #349
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md