Adding Kraken2 metagenomics classifier#355
Merged
jfy133 merged 18 commits intonf-core:devfrom Feb 21, 2020
Merged
Conversation
Closed
Closed
jfy133
requested changes
Feb 20, 2020
|
|
||
| * Taxonomic binner with alignment (`MALT`) | ||
| * Taxonomic binner without alignment (`Kraken2`) | ||
| * aDNA characteristic screening of taxonomically binned data (`MaltExtract`) |
Member
There was a problem hiding this comment.
Suggested change
| * aDNA characteristic screening of taxonomically binned data (`MaltExtract`) | |
| * aDNA characteristic screening of taxonomically binned data from MALT (`MaltExtract`) |
| ''' | ||
| INPUT: | ||
| infile (str): path to kraken report file | ||
| countlim (int): lower count threshold to report hit |
Member
There was a problem hiding this comment.
Suggested change
| countlim (int): lower count threshold to report hit | |
| countlim (int): lowest count threshold to report hit |
| '-o', | ||
| dest="output", | ||
| default=None, | ||
| help="Output file. Default = sources.csv") |
Member
There was a problem hiding this comment.
What does 'sources' mean here? Or is this a leftover from CoproID? Maybe should be changed to same on line 58?
Member
Author
There was a problem hiding this comment.
From kraken-nf actually ;)
Changed to use the name given by the CLI. (default="kraken_count_table.csv")
| respectively. Ensure your database matches the mode. Check the [MALT manual](http://ab.inf.uni-tuebingen.de/data/software/malt/download/manual.pdf) for more details. Default: 'BlastN' | ||
| respectively. Ensure your database matches the mode. Check the [MALT manual](http://ab.inf.uni-tuebingen.de/data/software/malt/download/manual.pdf) for more details. Default: 'BlastN' | ||
|
|
||
| Only when `--metagenomic_tool malt` |
Member
There was a problem hiding this comment.
Suggested change
| Only when `--metagenomic_tool malt` | |
| Only when `--metagenomic_tool malt` is also supplied |
While I thought this would've been implicit with the paramtere name, better to be explicit ;). The complete sentence can be applied to all below as well.
Member
Author
There was a problem hiding this comment.
Changed every occurence to your suggestion
| malt_min_support_mode = 'percent' | ||
| malt_min_support_percent = 0.01 | ||
| malt_min_support_reads = 1 | ||
| metagenomic_min_support_reads = 1 |
Member
There was a problem hiding this comment.
Duplicate here with line 168? Any reason why?
jfy133
approved these changes
Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Kraken2 metagenomics classifier
main.nfbinPR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md