Remove input cardinality warning for endorS.py when no bam filtering#362
Merged
apeltzer merged 3 commits intonf-core:devfrom Mar 1, 2020
jfy133:2-1-0-prep
Merged
Remove input cardinality warning for endorS.py when no bam filtering#362apeltzer merged 3 commits intonf-core:devfrom jfy133:2-1-0-prep
apeltzer merged 3 commits intonf-core:devfrom
jfy133:2-1-0-prep
Conversation
apeltzer
approved these changes
Mar 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the tin, is a minor patch to previous 2.1.0 prep PR. Basically in the input channel creation when not running bam filtering, add to the map a third 'dummy' element, but also add a condition that this isn't used within the endorS.py when bam filtering is not run.
PR checklist
Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md