Conversation
jfy133
requested review from
apeltzer and
maxibor
and removed request for
apeltzer
apeltzer
requested changes
Jun 23, 2020
Closed
maxibor
reviewed
Jun 23, 2020
maxibor
reviewed
Jun 23, 2020
maxibor
reviewed
Jun 23, 2020
maxibor
reviewed
Jun 23, 2020
maxibor
reviewed
Jun 23, 2020
maxibor
reviewed
Jun 23, 2020
| trim5 = "${params.bt2_trim5}" != 0 ? "--trim5 ${params.bt2_trim5}" : "" | ||
| trim3 = "${params.bt2_trim3}" != 0 ? "--trim3 ${params.bt2_trim3}" : "" | ||
| bt2n = "${params.bt2n}" != 0 ? "-N ${params.bt2n}" : "" | ||
| bt2l = "${params.bt2l}" != 0 ? "-L ${params.bt2l}" : "" |
Member
Author
There was a problem hiding this comment.
I've addressed this in the docs and doesn't require update because it overrides the default from --bt2_sensitivity i.e. if you supply a value here it will override the default, otherwise the -N parameter is not supplied.
maxibor
reviewed
Jun 23, 2020
maxibor
reviewed
Jun 23, 2020
Member
maxibor
left a comment
maxibor
left a comment
There was a problem hiding this comment.
A few modifications, mostly updating the default parameters
apeltzer
approved these changes
Jun 23, 2020
Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
maxibor
reviewed
Jun 23, 2020
Co-authored-by: Maxime Borry <maxibor@users.noreply.github.com>
Member
Author
|
Anymore @maxibor ?(heh, rhyming) |
maxibor
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/eager pull request
Many thanks for contributing to nf-core/eager!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker --paired_end).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md