Conversation
|
Definitely a very elegant addition, and I like the explanations in the help messages! If we go that route for improving the endogenous DNA calculation (which I'm not yet completely convinced of, see my comments to #522), we should clearly advertise it to users, especially for single-stranded library prep and very short reads. As this may become more and more common, we need to think whether it's safe to even recommend that as the default. |
apeltzer
requested changes
Jul 24, 2020
Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
apeltzer
approved these changes
Jul 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/eager pull request
This is to close #522 . This allows a user to turn off length filtering at adapteremoval and instead run length filtering on mapped (only!) BAM files.
Therefore all reads in a library should in principle go into mapping after going through AdapterRemoval (and after merging to account for pairs, and assuming the vast majority of read pairs overlap), and thus will give a more realistic endogenous DNA value for 'economic' reasons.
PR checklist
nextflow run . -profile test,docker --paired_end).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md