Skip to content

Nuclear contamination per library in MQC, plus fixes and cleanup of channels by james#526

Merged
jfy133 merged 8 commits intonf-core:devfrom
TCLamnidis:dev
Jul 23, 2020
Merged

Nuclear contamination per library in MQC, plus fixes and cleanup of channels by james#526
jfy133 merged 8 commits intonf-core:devfrom
TCLamnidis:dev

Conversation

@TCLamnidis
Copy link
Copy Markdown
Collaborator

@TCLamnidis TCLamnidis commented Jul 22, 2020

  1. Fixed deduplication output logic
  2. Cleanup of channels that were not being used.
  3. Updated parsing of nuclear contamination output to be compatible with latest version of angsd (0.933)
  4. Nuclear contamination output per library now correctly shown in MQC report. Before, the nuclear contamination estimates were getting their own row in the general stats table because the process was written before the tuple input and inferred naming form filenames.

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker --paired_end).
  • Make sure your code lints (nf-core lint .).
  • CHANGELOG.md is updated

Comment thread CHANGELOG.md Outdated
@jfy133 jfy133 self-requested a review July 23, 2020 09:26
@jfy133 jfy133 merged commit f3ca5fc into nf-core:dev Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants