Skip to content

Circularmapper filter fix#639

Merged
jfy133 merged 10 commits intonf-core:devfrom
jfy133:circularmapper-filter-fix
Dec 23, 2020
Merged

Circularmapper filter fix#639
jfy133 merged 10 commits intonf-core:devfrom
jfy133:circularmapper-filter-fix

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Dec 21, 2020

nf-core/eager pull request

This PR is to close #638 - a bug reported by @zhongxing123 where the circularmapper boolean option was flipped.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

Hi @jfy133,

It looks like this pull-request is has been made against the jfy133/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the jfy133/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@jfy133 jfy133 changed the base branch from master to dev December 21, 2020 09:48
@jfy133 jfy133 requested a review from a team December 21, 2020 12:34
Comment thread nextflow_schema.json Outdated
Comment thread main.nf Outdated
Comment thread main.nf Outdated
jfy133 and others added 2 commits December 21, 2020 14:48
Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me - wait fro Stephens reply maybe.

@jfy133 jfy133 merged commit 7f10eae into nf-core:dev Dec 23, 2020
@jfy133 jfy133 deleted the circularmapper-filter-fix branch March 15, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

params.circularfilter ? '' : '-f true -x false'

3 participants