Circularmapper filter fix#639
Merged
jfy133 merged 10 commits intonf-core:devfrom Dec 23, 2020
Merged
Conversation
|
Hi @jfy133, It looks like this pull-request is has been made against the jfy133/eager You do not need to close this PR, you can change the target branch to Thanks again for your contribution! |
TCLamnidis
reviewed
Dec 21, 2020
TCLamnidis
reviewed
Dec 21, 2020
TCLamnidis
reviewed
Dec 21, 2020
Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
apeltzer
approved these changes
Dec 23, 2020
Member
apeltzer
left a comment
There was a problem hiding this comment.
Fine by me - wait fro Stephens reply maybe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/eager pull request
This PR is to close #638 - a bug reported by @zhongxing123 where the circularmapper boolean option was flipped.
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).