Fix kraken db loading fromPath#673
Conversation
jfy133
left a comment
There was a problem hiding this comment.
CI fail :(
Error executing process > 'decomp_kraken'
Caused by:
Process `decomp_kraken` terminated with an error exit status (1)
Command executed:
tar xvzf eager_test.tar.gz
mkdir -p eager_test
mv *.k2d eager_test
Command exit status:
1
Command output:
eager_test/
eager_test/opts.k2d
eager_test/seqid2taxid.map
eager_test/taxo.k2d
eager_test/hash.k2d
Command error:
mv: cannot stat '*.k2d': No such file or directory
jfy133
left a comment
There was a problem hiding this comment.
See comment above about CI fail
|
Guessing from the conversation still some fixes required no ? |
jfy133
left a comment
There was a problem hiding this comment.
This in principle to me now looks good. CI tests do pass (the one fail is the flakiness on the BAM filtering thing).
@maxibor please decide if you want to change fromPath to file() (see Harshil's comment), and then proceed with merging!
|
As I can't see |
Feel free to merge! <- SCRAP THAT! See Slack - only one sample was run, needs a |
|
Yeah add either |
|
Went with |
|
See slack - solves the issue 👍🏻 |
Kraken database loading fixed to
fromPathmethod for channel creationPR checklist
nf-core lint .).nextflow run . -profile test,docker).CHANGELOG.mdis updated.