Skip to content

Upgrades HOPS so it doesn't cause MultiQC fail#696

Merged
jfy133 merged 2 commits intodevfrom
mqc-hops-fix
Mar 12, 2021
Merged

Upgrades HOPS so it doesn't cause MultiQC fail#696
jfy133 merged 2 commits intodevfrom
mqc-hops-fix

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Mar 11, 2021

Checks are currently failing because MultiQC fails as there is a bug in the HOPS post-processing script. The bug has been fixed in HOPS 0.35, so this bumps the env.yaml.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 changed the base branch from master to dev March 11, 2021 19:57
@github-actions
Copy link
Copy Markdown

Hi @jfy133,

It looks like this pull-request is has been made against the nf-core/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@jfy133 jfy133 merged commit aed30d9 into dev Mar 12, 2021
@jfy133 jfy133 deleted the mqc-hops-fix branch March 12, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants