Skip to content

DSL2: single-genome indexing#926

Merged
jfy133 merged 9 commits intodevfrom
dsl2-indexing
Oct 10, 2022
Merged

DSL2: single-genome indexing#926
jfy133 merged 9 commits intodevfrom
dsl2-indexing

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Oct 10, 2022

Adds indexing for when a user supplies a single fasta file for us as a reference.

I will do a separate PR for the input TSV.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested review from a team, FriederikeHanssen and maxulysse October 10, 2022 12:45
@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Oct 10, 2022

@nf-core-bot fix linting

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Oct 10, 2022

@nf-core-bot fix linting

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 10, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 996d101

+| ✅ 157 tests passed       |+
!| ❗  19 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Fill in short bullet-pointed list of the default steps in the pipeline
  • pipeline_todos - TODO string in README.md: Update the example "typical command" below used to run the pipeline
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in nextflow.config: Specify your pipeline's command line flags
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in test.config: Specify the paths to your test data on nf-core/test-datasets
  • pipeline_todos - TODO string in test.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in eager.nf: Add all file path parameters for the pipeline to the list below
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in output.md: Write this documentation describing your workflow's output

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-10-10 13:47:26

Comment thread conf/modules.config Outdated
Comment thread conf/test.config
Comment thread nextflow_schema.json Outdated
Comment thread nextflow_schema.json Outdated
Comment thread subworkflows/local/reference_indexing_single.nf
jfy133 and others added 2 commits October 10, 2022 15:30
Co-authored-by: FriederikeHanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
Copy link
Copy Markdown

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jfy133 jfy133 merged commit 098b0b7 into dev Oct 10, 2022
@TCLamnidis TCLamnidis deleted the dsl2-indexing branch May 12, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants