Skip to content
This repository was archived by the owner on May 7, 2019. It is now read-only.

Removed problematic local executor specification#25

Merged
ewels merged 1 commit intonf-core:masterfrom
alneberg:master
Aug 6, 2018
Merged

Removed problematic local executor specification#25
ewels merged 1 commit intonf-core:masterfrom
alneberg:master

Conversation

@alneberg
Copy link
Copy Markdown
Member

@alneberg alneberg commented Aug 6, 2018

@alneberg
Copy link
Copy Markdown
Member Author

alneberg commented Aug 6, 2018

@ewels, I think this PR is faulty? Feel free to close this one if you agree.

@ewels
Copy link
Copy Markdown
Member

ewels commented Aug 6, 2018

Faulty how? Looks good to me!

@ewels
Copy link
Copy Markdown
Member

ewels commented Aug 6, 2018

The tests are failing because the travis config hasn’t been set up yet (it’s blank).

@ewels ewels merged commit 6b5b654 into nf-core:master Aug 6, 2018
@alneberg
Copy link
Copy Markdown
Member Author

alneberg commented Aug 7, 2018

Ok, if you think it looks good, then I'm pleased! I just thought it was one of those other cases where there were no "script" defined so that it would actually make sense to force it to run locally?

@pditommaso
Copy link
Copy Markdown

In this case it's fine to have executor 'local' because the process execute groovy code, not an bash script. Removing the localexecutor it will print a warning message when running the workflow in a cluster/cloud.

@ewels
Copy link
Copy Markdown
Member

ewels commented Aug 7, 2018

Yes, I didn't read far enough down the diff to realise that it was an exec not a script. The process name has been updated in other repos to use a script and run as a regular process, so I think it's fine to remove it like this, as we'll almost certainly update it further in the future.

Thanks for the clarification though @pditommaso! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants