Skip to content

Use nf-test in CI#116

Merged
kbestak merged 10 commits intonf-core:devfrom
kbestak:test_updates
May 2, 2025
Merged

Use nf-test in CI#116
kbestak merged 10 commits intonf-core:devfrom
kbestak:test_updates

Conversation

@kbestak
Copy link
Copy Markdown
Collaborator

@kbestak kbestak commented Apr 2, 2025

Adapted the CI script to run nf-test on files that have been changed.
Updated multiqc module.
Updated nftignore

Temporary fix - mindagap/duplicatefinder is missing the stub section - temporarily, the markedDups.txt is removed from testing.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/molkart branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2025

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @kbestak,

It looks like this pull-request is has been made against the kbestak/nf_molkart master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the kbestak/nf_molkart dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@kbestak kbestak changed the base branch from master to dev April 2, 2025 15:32
Comment thread tests/main.nf.test.snap
"nextflow": "24.10.5"
},
"timestamp": "2025-03-26T15:09:22.923283861"
"timestamp": "2025-04-03T11:20:29.322813595"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a timestamp in the snapshot?!

@FloWuenne
Copy link
Copy Markdown
Collaborator

Looks good, just wanted you to confirm timestamp existence as wanted or not in the snapshots. Otherwise, feel free to merge @kbestak !

Copy link
Copy Markdown
Collaborator

@FloWuenne FloWuenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 . Let's merge this and then do the template update @kbestak !

@kbestak
Copy link
Copy Markdown
Collaborator Author

kbestak commented May 2, 2025

The timestamp is included by defaut and it is just the snapshot's metadata, thanks for the review, I'll get the template update PR sorted out now.

@kbestak kbestak merged commit 6ee8674 into nf-core:dev May 2, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants