Skip to content

Prepare for 2.6 release#131

Merged
maxulysse merged 16 commits intonf-core:devfrom
maxulysse:prepare2.6
Feb 28, 2020
Merged

Prepare for 2.6 release#131
maxulysse merged 16 commits intonf-core:devfrom
maxulysse:prepare2.6

Conversation

@maxulysse
Copy link
Copy Markdown
Member

nf-core/sarek pull request

  • Prepare for the 2.6 release that would be the last one before DSL 2

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse added the release This PR is for a release label Feb 27, 2020
@maxulysse maxulysse added this to the 2.6 milestone Feb 27, 2020
@maxulysse maxulysse requested review from a team and ggabernet February 27, 2020 13:13
@maxulysse maxulysse self-assigned this Feb 27, 2020
@maxulysse
Copy link
Copy Markdown
Member Author

@ggabernet I tried to refactor the ASCAT process to simplify it. I just tested it and it worked on our server :-D

@maxulysse maxulysse marked this pull request as ready for review February 28, 2020 08:06
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch with all the missing cookiecutter statements 👍

@maxulysse maxulysse added update Tool update and removed work in progress labels Feb 28, 2020
@maxulysse
Copy link
Copy Markdown
Member Author

LGTM, nice catch with all the missing cookiecutter statements +1

I just noticed it with a CI test that failed for random reason.

But now I'm wondering if there's more around, I'll do a quick check now

@maxulysse
Copy link
Copy Markdown
Member Author

ok, it looks like there's no cookiecutter statements left anywhere.
It could be a good idea to have nf-core lint check for that.

Copy link
Copy Markdown
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release This PR is for a release update Tool update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants