Skip to content

Update aws megatests GH actions#150

Merged
maxulysse merged 4 commits intonf-core:devfrom
ggabernet:dev
Mar 6, 2020
Merged

Update aws megatests GH actions#150
maxulysse merged 4 commits intonf-core:devfrom
ggabernet:dev

Conversation

@ggabernet
Copy link
Copy Markdown
Member

nf-core/sarek pull request

Fix --outdir param

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@ggabernet ggabernet requested a review from maxulysse as a code owner March 6, 2020 15:15
@maxulysse
Copy link
Copy Markdown
Member

I think you still have issues with the credentials

@ggabernet
Copy link
Copy Markdown
Member Author

https://github.com/nf-core/sarek/settings/secrets

So it seems like secrets are not passed to pull requests, so we would need to merge to fully test it.
It also makes sense, as otherwise, anyone making a PR could use our secrets for testing :)

@maxulysse maxulysse merged commit a6037cd into nf-core:dev Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants