Skip to content

Add CNVkit copy number variant caller#153

Merged
maxulysse merged 8 commits intonf-core:devfrom
adrlar:dev
May 18, 2020
Merged

Add CNVkit copy number variant caller#153
maxulysse merged 8 commits intonf-core:devfrom
adrlar:dev

Conversation

@adrlar
Copy link
Copy Markdown
Contributor

@adrlar adrlar commented Mar 9, 2020

nf-core/sarek pull request

This is a draft PR for adding CNVkit as a process to sarek. It is just a start.

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse self-requested a review March 9, 2020 15:10
@maxulysse maxulysse added the enhancement New feature or request label Mar 9, 2020
@maxulysse maxulysse added this to the 3.0 milestone Mar 9, 2020
@maxulysse maxulysse changed the title Adding CNVkit copy number variant caller Add CNVkit copy number variant caller May 18, 2020
@maxulysse maxulysse marked this pull request as ready for review May 18, 2020 15:23
Copy link
Copy Markdown
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@maxulysse
Copy link
Copy Markdown
Member

@adrlar Thanks a lot for the PR, sorry it took so long from my part to actually review it, but merging it now, so it'll be available for the 2.6 release.

@maxulysse maxulysse merged commit 3341c1f into nf-core:dev May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants