Add AWS megatest GHA#154
Merged
ggabernet merged 14 commits intonf-core:devfrom Mar 12, 2020
FriederikeHanssen:aws_megatests2
Merged
Add AWS megatest GHA#154ggabernet merged 14 commits intonf-core:devfrom FriederikeHanssen:aws_megatests2
ggabernet merged 14 commits intonf-core:devfrom
FriederikeHanssen:aws_megatests2
Conversation
ggabernet
requested changes
Mar 11, 2020
Member
ggabernet
left a comment
ggabernet
left a comment
There was a problem hiding this comment.
The aws test workflow is called awstest.yml. Do you think it would be possible to just add your edits to that one?
Contributor
Author
Yes of course. Dev branch of my fork wasn't up-to-date, so I oversaw the already existing file. It is done |
ggabernet
approved these changes
Mar 11, 2020
Member
ggabernet
left a comment
ggabernet
left a comment
There was a problem hiding this comment.
Two small suggestions, that will directly add -with-tower as well :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the GHA for aws megatests. It was tested here https://github.com/ggabernet/nf-core-sarek/pull/3
Since the access tokens are not widely shared, I can not run a complete test on my account. However, if we set them up for this repo it should work.
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md