Final polishing#164
Merged
maxulysse merged 24 commits intonf-core:devfrom Mar 27, 2020
Merged
Conversation
Member
Author
|
Couldn't reproduce #118 so I'm currently giving up on trying to fix it, and going on with the release. |
ggabernet
approved these changes
Mar 27, 2020
Member
|
Looks good to me, I just found two small things in the comments where I was not sure if it was intended or not |
maxulysse
commented
Mar 27, 2020
Co-Authored-By: Gisela Gabernet <gisela.gabernet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/sarek pull request
Trying to fix Mutect2 process skipped #118Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md