Skip to content

markdup_java_options docs#167

Merged
maxulysse merged 3 commits intonf-core:devfrom
ggabernet:dev
Mar 30, 2020
Merged

markdup_java_options docs#167
maxulysse merged 3 commits intonf-core:devfrom
ggabernet:dev

Conversation

@ggabernet
Copy link
Copy Markdown
Member

Should solve #166

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@ggabernet ggabernet requested a review from maxulysse as a code owner March 27, 2020 16:48
@maxulysse
Copy link
Copy Markdown
Member

Wonderful, while you're at it, can you change the \--reads`to--input`:
https://github.com/nf-core/sarek/blob/38c7542a94c375aa2f6202ffa658e992e55892fa/docs/usage.md#--reads
I just noticed this error in the same markdown document.

@ggabernet
Copy link
Copy Markdown
Member Author

sure, just did that :)

Comment thread docs/usage.md Outdated
Comment thread docs/usage.md Outdated
Copy link
Copy Markdown
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for everything

@maxulysse maxulysse merged commit 07d63e4 into nf-core:dev Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants