Updates on the minimal settings#197
Merged
maxulysse merged 11 commits intonf-core:devfrom Apr 29, 2020
Merged
Conversation
Member
Author
|
Just missing some docs |
mahesh-panchal
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one should be the last one on this series from me.
I also included some minor refactoring (sorry).
prepare_recalibrationWe're actually already saving the BAM and index files for the next step, but as recalibration can only happen with some know variants, there was actually no plan to restart from the calculation of these recalibration tables.
It is now possible.
The idea is to allow people to do preprocessing up until the preparation of the recalibration tables, and follow by some variant calling to allow a creation of know variants resource which can later be used to calculate and do the recalibration and then do some proper variant calling.
cf: https://gatkforums.broadinstitute.org/gatk/discussion/1247/what-should-i-use-as-known-variants-sites-for-running-tool-x
DuplicateMarkedshould have beenDuplicatesMarkednf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md