Skip to content

--save_bam_mapped works for every settings#202

Merged
maxulysse merged 2 commits intonf-core:devfrom
maxulysse:save_bam_mapped
May 8, 2020
Merged

--save_bam_mapped works for every settings#202
maxulysse merged 2 commits intonf-core:devfrom
maxulysse:save_bam_mapped

Conversation

@maxulysse
Copy link
Copy Markdown
Member

nf-core/sarek pull request

it was working only for minimal settings before, it's now enabled for every settings

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team May 8, 2020 12:30
Copy link
Copy Markdown
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Oups, I had also missed the publish_dir_mode in my last review...

@maxulysse maxulysse merged commit 5db3d24 into nf-core:dev May 8, 2020
@maxulysse maxulysse deleted the save_bam_mapped branch May 8, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants