Skip to content

More improvments#21

Merged
maxulysse merged 22 commits intonf-core:devfrom
maxulysse:nf-core-lint
Aug 12, 2019
Merged

More improvments#21
maxulysse merged 22 commits intonf-core:devfrom
maxulysse:nf-core-lint

Conversation

@maxulysse
Copy link
Copy Markdown
Member

@maxulysse maxulysse commented Aug 8, 2019

  • Improve MD linting
  • MD linting is now a stage on Travis-CI
  • Tests are sorted, timewise
  • Use kraken profile for Jenkins testing
  • Use YAML anchors to simplify circle CI image building and deployment to DockerHub
  • Improve testing script (remove ALL from TEST)
  • Use direct link to slack channel
  • Usual code polishing
  • New genomes.config for genomes without AWS iGenomes
  • smallGRCh37 is now in genomes.config

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse requested review from a team and szilvajuhos August 8, 2019 15:14
@maxulysse maxulysse marked this pull request as ready for review August 12, 2019 07:43
Copy link
Copy Markdown
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fine with me. But keep in mind that you need to deal with the linting issues at some point.

@maxulysse maxulysse merged commit ca2a0b0 into nf-core:dev Aug 12, 2019
@maxulysse
Copy link
Copy Markdown
Member Author

@apeltzer told me that he'll help me with that.
But I do agree, I need at some point to make linting work, either by changing sarek, or by changing linting...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants