Skip to content

aply changes from comments#223

Merged
maxulysse merged 1 commit intonf-core:devfrom
maxulysse:2.6.1_PR_comments
Jun 23, 2020
Merged

aply changes from comments#223
maxulysse merged 1 commit intonf-core:devfrom
maxulysse:2.6.1_PR_comments

Conversation

@maxulysse
Copy link
Copy Markdown
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team June 23, 2020 07:53
Copy link
Copy Markdown
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy 🙂 LGTM!

@maxulysse maxulysse merged commit ff2ac6a into nf-core:dev Jun 23, 2020
@maxulysse maxulysse deleted the 2.6.1_PR_comments branch June 23, 2020 08:48
@maxulysse maxulysse mentioned this pull request Jun 23, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants