Skip to content

Add Subworkflow Build_Indices for switch to DSL2#238

Merged
ggabernet merged 7 commits intonf-core:dsl2from
FriederikeHanssen:add_index
Jul 15, 2020
Merged

Add Subworkflow Build_Indices for switch to DSL2#238
ggabernet merged 7 commits intonf-core:dsl2from
FriederikeHanssen:add_index

Conversation

@FriederikeHanssen
Copy link
Copy Markdown
Contributor

Add subworklow for building indices

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@FriederikeHanssen FriederikeHanssen changed the title Add index Add Subworkflow Build_Indices for switch to DSL2 Jul 15, 2020
@ggabernet
Copy link
Copy Markdown
Member

ggabernet commented Jul 15, 2020

The simple test does not pass now any more

@FriederikeHanssen FriederikeHanssen requested a review from a team July 15, 2020 13:40
@ggabernet
Copy link
Copy Markdown
Member

yay! test test passes again :)

Copy link
Copy Markdown
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Indices are being built :) Maybe let's let @maxulysse have a look if he's fine with it?

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review July 15, 2020 13:48
Comment thread CHANGELOG.md

## [dev](https://github.com/nf-core/sarek/tree/dev)

- [#234](https://github.com/nf-core/sarek/pull/234) -Switching to DSL2
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this line to DSL2 too, no?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in the next PR coming :)

Copy link
Copy Markdown
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's amazing

@ggabernet ggabernet merged commit 65ea8da into nf-core:dsl2 Jul 15, 2020
@maxulysse maxulysse added the DSL2 label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants