Works with Nextflow.20.06.0 edge and has optional processes#244
Merged
maxulysse merged 6 commits intonf-core:dsl2from Jul 16, 2020
Merged
Works with Nextflow.20.06.0 edge and has optional processes#244maxulysse merged 6 commits intonf-core:dsl2from
maxulysse merged 6 commits intonf-core:dsl2from
Conversation
maxulysse
requested review from
FriederikeHanssen and
ggabernet
and removed request for
FriederikeHanssen
| if (!(params.bwa) && params.fasta && 'mapping' in step) | ||
| result_bwa = BWAMEM2_INDEX(fasta) | ||
| else | ||
| result_bwa = Channel.empty() |
Contributor
There was a problem hiding this comment.
Glad it works like this, but unhappy with the optics
Member
Author
There was a problem hiding this comment.
We'll improve it at some point
FriederikeHanssen
approved these changes
Jul 16, 2020
| def command = "nextflow run nf-core/sarek --input sample.tsv -profile docker" | ||
| log.info Headers.nf_core(workflow, params.monochrome_logs) | ||
| log.info Schema.params_help("$baseDir/nextflow_schema.json", command) | ||
| exit 0 |
Contributor
There was a problem hiding this comment.
Why is this removed?
Member
Author
There was a problem hiding this comment.
Moved it back to the top, and just removed the Headers part from it, I think it's useless in the help context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md