Improvment on preprocessing#264
Merged
maxulysse merged 5 commits intonf-core:dsl2from Aug 6, 2020
Merged
Conversation
FriederikeHanssen
approved these changes
Aug 6, 2020
Contributor
FriederikeHanssen
left a comment
FriederikeHanssen
left a comment
There was a problem hiding this comment.
Looks awesome!
| [ ! -f ${prefix}.bam ] && ln -s ${bam} ${prefix}.bam | ||
|
|
||
| samtools index ${prefix}.bam | ||
| """ |
Contributor
There was a problem hiding this comment.
Is this from Harshil's modules?
Member
Author
There was a problem hiding this comment.
I got inspired from fastqc module
Contributor
|
Can we merge? Think there is a fix in your code, that I need somewhere in the VariantCalling and copying out one thing has lead to a cascade of changes. Much rather merge und fetch this code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md