Skip to content

Variantcalling#266

Merged
FriederikeHanssen merged 9 commits intonf-core:dsl2from
FriederikeHanssen:dsl2_variantcalling
Sep 21, 2020
Merged

Variantcalling#266
FriederikeHanssen merged 9 commits intonf-core:dsl2from
FriederikeHanssen:dsl2_variantcalling

Conversation

@FriederikeHanssen
Copy link
Copy Markdown
Contributor

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse added this to the 3.0 milestone Aug 31, 2020
@maxulysse maxulysse added the DSL2 label Aug 31, 2020
@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review September 21, 2020 12:25
@FriederikeHanssen
Copy link
Copy Markdown
Contributor Author

Undrafting so we can merge efforts and g from there

@FriederikeHanssen
Copy link
Copy Markdown
Contributor Author

Will merge, even if it means tests are failing now

@FriederikeHanssen FriederikeHanssen merged commit 355ca6f into nf-core:dsl2 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants