tiny fixes and update logo and publications#284
Merged
maxulysse merged 6 commits intonf-core:devfrom Sep 28, 2020
Merged
Conversation
mashehu
reviewed
Sep 28, 2020
| "type": "boolean", | ||
| "fa_icon": "fas fa-cut", | ||
| "description": "Run Trim Galore" | ||
| "description": "Run Trim Galore", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Run Trim Galore", | |
| "description": "Run Trim Galore.", |
mashehu
reviewed
Sep 28, 2020
| "fa_icon": "fas fa-cut", | ||
| "description": "Remove bp from the 5' end of read 1", | ||
| "help_text": "With Trim Galore" | ||
| "help_text": "With Trim Galore", |
Contributor
There was a problem hiding this comment.
not a very helpful text, in my opinion. Would easily also fit into the description.
mashehu
reviewed
Sep 28, 2020
| "clip_r1": { | ||
| "type": "integer", | ||
| "fa_icon": "fas fa-cut", | ||
| "description": "Remove bp from the 5' end of read 1", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Remove bp from the 5' end of read 1", | |
| "description": "Number of bp removed from the 5' end of read 1.", |
mashehu
reviewed
Sep 28, 2020
| "fa_icon": "fas fa-save", | ||
| "description": "Specify how many reads should be contained in the split FastQ file", | ||
| "help_text": "If none specified, FastQs won't be split" | ||
| "description": "Save trimmed FastQ file intermediates", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Save trimmed FastQ file intermediates", | |
| "description": "Save trimmed FastQ file intermediates.", |
mashehu
reviewed
Sep 28, 2020
| "description": "Specify how many reads should be contained in the split FastQ file", | ||
| "help_text": "If none specified, FastQs won't be split" | ||
| "description": "Save trimmed FastQ file intermediates", | ||
| "help_text": "If none specified, FastQs won't be split", |
Contributor
There was a problem hiding this comment.
Suggested change
| "help_text": "If none specified, FastQs won't be split", | |
| "help_text": "If none specified, FastQs won't be split.", |
mashehu
reviewed
Sep 28, 2020
| "fa_icon": "fas fa-cut", | ||
| "description": "Save trimmed FastQ file intermediates", | ||
| "help_text": "If not used, FastQs won't be split" | ||
| "description": "Specify how many reads should be contained in the split FastQ file", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Specify how many reads should be contained in the split FastQ file", | |
| "description": "Specify how many reads should be contained in the split FastQ file.", |
mashehu
reviewed
Sep 28, 2020
| "fa_icon": "fas fa-memory", | ||
| "description": "Establish values for GATK MarkDuplicates memory consumption", | ||
| "help_text": "See https://github.com/SciLifeLab/Sarek/pull/689" | ||
| "help_text": "See https://github.com/SciLifeLab/Sarek/pull/689", |
Contributor
There was a problem hiding this comment.
Suggested change
| "help_text": "See https://github.com/SciLifeLab/Sarek/pull/689", | |
| "help_text": "See [https://github.com/SciLifeLab/Sarek/pull/689](https://github.com/SciLifeLab/Sarek/pull/689)", |
Member
Author
|
@mashehu thanks for the comments, I'll make another PR with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md