Skip to content

Add troubleshooting section to docs with an entry on Spark issues#294

Merged
maxulysse merged 6 commits intonf-core:devfrom
jfnavarro:dev
Oct 20, 2020
Merged

Add troubleshooting section to docs with an entry on Spark issues#294
maxulysse merged 6 commits intonf-core:devfrom
jfnavarro:dev

Conversation

@jfnavarro
Copy link
Copy Markdown
Contributor

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • Documentation in docs is updated

Learn more about contributing: CONTRIBUTING.md

@jfnavarro jfnavarro requested a review from maxulysse as a code owner October 20, 2020 15:00
Comment thread docs/README.md Outdated
Comment thread docs/usage.md
Comment thread docs/usage.md Outdated
Copy link
Copy Markdown
Contributor Author

@jfnavarro jfnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread docs/usage.md Outdated

### Spark related issues

If you have problems running processes that make use of Spark such as ```MarkDuplicates```.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have problems running processes that make use of Spark such as ```MarkDuplicates```.
If you have problems running processes that make use of Spark such as ```MarkDuplicates```.

Comment thread docs/usage.md Outdated
Comment thread docs/usage.md Outdated
Comment thread docs/usage.md Outdated
Comment thread docs/usage.md Outdated

```bash
* soft nofile 65535
* hard nofile 65535
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* hard nofile 65535
* hard nofile 65535

Comment thread docs/usage.md Outdated
OPTIONS=”—default-ulimit nofile=65535:65535"
```

Re-start your session.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Re-start your session.
Re-start your session.

Copy link
Copy Markdown
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good with markdownlint now.

Thanks @jfnavarro for the PR.

That's exactly what I had in mind.

@maxulysse maxulysse merged commit cce883e into nf-core:dev Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants