Skip to content

adding nf-core lint#31

Merged
maxulysse merged 5 commits intonf-core:devfrom
maxulysse:lint
Sep 4, 2019
Merged

adding nf-core lint#31
maxulysse merged 5 commits intonf-core:devfrom
maxulysse:lint

Conversation

@maxulysse
Copy link
Copy Markdown
Member

  • Remove extra CI from Travis CI and GitHub Actions nf-core CI to new GitHub Actions nf-core extra CI
  • update code according to nf-core lint:
    • badges
    • rcolorbrewer version
    • remove TODO nf-core comments)

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

* Remove extra CI from .travis.yml and GitHub Actions nf-core CI
* Add new nf-core extra CI
* Fix badges according to nf-core lint
* Remove TODO nf-core comments in code
* Use 1.1_2 version for rcolorbrewer, according to nf-core lint
@maxulysse maxulysse requested review from a team and alneberg September 4, 2019 12:37
@maxulysse maxulysse merged commit 70fb026 into nf-core:dev Sep 4, 2019
@maxulysse maxulysse deleted the lint branch September 4, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants