Skip to content

Update docs + some fix#329

Merged
maxulysse merged 7 commits intonf-core:devfrom
maxulysse:dev_docs
Jan 20, 2021
Merged

Update docs + some fix#329
maxulysse merged 7 commits intonf-core:devfrom
maxulysse:dev_docs

Conversation

@maxulysse
Copy link
Copy Markdown
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

Comment thread main.nf Outdated
Comment thread main.nf Outdated
Comment thread main.nf Outdated
@maxulysse
Copy link
Copy Markdown
Member Author

It's true that we did update the Control-FREEC version

@maxulysse
Copy link
Copy Markdown
Member Author

@jfnavarro @szilvajuhos this time it should finally be good, right?

@jfnavarro
Copy link
Copy Markdown
Contributor

It looks good to me!

Copy link
Copy Markdown
Contributor

@jfnavarro jfnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

Comment thread main.nf Outdated
Comment thread main.nf Outdated
Comment thread main.nf Outdated
Comment thread main.nf Outdated
Copy link
Copy Markdown
Contributor

@jfnavarro jfnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Tested locally!

@maxulysse maxulysse merged commit a20a33e into nf-core:dev Jan 20, 2021
@maxulysse maxulysse deleted the dev_docs branch January 20, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants