Bump sarek to 3.0dev#333
Merged
maxulysse merged 18 commits intonf-core:devfrom Jan 26, 2021
Merged
Conversation
|
|
||
| # Add conda installation dir to PATH (instead of doing 'conda activate') | ||
| ENV PATH /opt/conda/envs/nf-core-sarek-snpeff-2.7dev/bin:$PATH | ||
| ENV PATH /opt/conda/envs/nf-core-sarek-snpeff-dev/bin:$PATH |
Contributor
There was a problem hiding this comment.
not snpeff-3.0dev?
FriederikeHanssen
approved these changes
Jan 26, 2021
Contributor
FriederikeHanssen
left a comment
FriederikeHanssen
left a comment
There was a problem hiding this comment.
Looks good. Just the question of whether it should be labeled dev or 3.0dev everywhere. I don't have a preference either way
Member
Author
Merged before reading comments 🤦 We can always fix that later... |
Contributor
|
Ah no worries. It's a tiny thing about consistency. won't change anything in whether it runs or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).