Skip to content

Avoid collision in MultiQC#38

Merged
maxulysse merged 7 commits intonf-core:devfrom
maxulysse:BUG
Sep 27, 2019
Merged

Avoid collision in MultiQC#38
maxulysse merged 7 commits intonf-core:devfrom
maxulysse:BUG

Conversation

@maxulysse
Copy link
Copy Markdown
Member

  • File names before merge is based on ${idSample}_${idRun} instead of ${idRun}

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse requested review from a team and szilvajuhos September 27, 2019 06:33
@maxulysse maxulysse added the bug Something isn't working label Sep 27, 2019
@maxulysse maxulysse merged commit dc6cf30 into nf-core:dev Sep 27, 2019
@maxulysse maxulysse deleted the BUG branch September 27, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants