Skip to content

Fix: issues with known_sites channels#418

Merged
maxulysse merged 3 commits intonf-core:devfrom
maxulysse:dev_tbi
Aug 3, 2021
Merged

Fix: issues with known_sites channels#418
maxulysse merged 3 commits intonf-core:devfrom
maxulysse:dev_tbi

Conversation

@maxulysse
Copy link
Copy Markdown
Member

To be merged after #417

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Copy Markdown
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, think its good to merge once CI is done

@maxulysse maxulysse merged commit 474706c into nf-core:dev Aug 3, 2021
@maxulysse maxulysse deleted the dev_tbi branch August 3, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants