Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
5f66efd
nf-core modules update all
FriederikeHanssen Dec 6, 2021
1b0632e
replace suffix for nf-core modules with prefix
FriederikeHanssen Dec 6, 2021
c88c0b6
one ci test at a time
FriederikeHanssen Dec 6, 2021
ab931d8
one ci test at a time
FriederikeHanssen Dec 6, 2021
cea0e31
one ci test at a time, tmor normal pair passes locally but not here
FriederikeHanssen Dec 6, 2021
998e80d
one ci test at a time, tmor normal pair passes locally but not here
FriederikeHanssen Dec 6, 2021
cbce8e4
one ci test at a time
FriederikeHanssen Dec 6, 2021
da2e677
one ci test at a time
FriederikeHanssen Dec 6, 2021
949acfe
one ci test at a time, annotation wf not passing, some issue with 'no…
FriederikeHanssen Dec 6, 2021
941d089
Update modules again
FriederikeHanssen Dec 6, 2021
aec7bcf
Add meta field because updated samtools faidx modules
FriederikeHanssen Dec 6, 2021
a0b7a24
Fix samtools input + channel magic instead of module changes
FriederikeHanssen Dec 6, 2021
8bc2837
Revert changes to build_intervals module
FriederikeHanssen Dec 6, 2021
9008a5f
Add name to samtools faidx call & turn off annotation sw for debugging
FriederikeHanssen Dec 6, 2021
269b37f
Fix annotation subworkflow
FriederikeHanssen Dec 6, 2021
117f152
Move 'parts' logic to config
FriederikeHanssen Dec 6, 2021
2b6b512
apprantly splitfastq test got overwritten at som epoint
FriederikeHanssen Dec 6, 2021
5a5bdda
:facepalm: update ci file
FriederikeHanssen Dec 6, 2021
18c26c0
Add yml for testing, edit config to latest nf release
FriederikeHanssen Dec 7, 2021
903f388
Remove local tabix module, update tabix & seqkit
FriederikeHanssen Dec 7, 2021
be6397b
Update snpeff & vep
FriederikeHanssen Dec 7, 2021
976625f
use correct path for including tabix modules
FriederikeHanssen Dec 7, 2021
7708266
Removing parts from bwa mem, splot tests not working :cry:
FriederikeHanssen Dec 7, 2021
9850be7
apply code review
FriederikeHanssen Dec 7, 2021
a1ff42d
fix split tests (hopefully), test separatly
FriederikeHanssen Dec 7, 2021
48dc9d8
add tests back in (except annotation, because it fails)
FriederikeHanssen Dec 7, 2021
915ade2
add tests back in (except annotation, because it fails)
FriederikeHanssen Dec 7, 2021
06732dc
annotation wf runs locally
FriederikeHanssen Dec 8, 2021
d7eceae
install gatk4 modules
FriederikeHanssen Dec 8, 2021
ba78251
add nf-core gatk4 modules in another PR as some upstream fixes are re…
FriederikeHanssen Dec 8, 2021
fc89462
replace VEP sw with nf-core/vep sw
FriederikeHanssen Dec 8, 2021
06d100b
add snpeff sw and properly import it
FriederikeHanssen Dec 8, 2021
5061cbc
update config with changed module and sw names
FriederikeHanssen Dec 8, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
- 'aligner'
- 'annotation'
- 'default'
- 'split_fastq'
- 'gatk4_spark'
- 'save_bam_mapped'
- 'skip_markduplicates'
Expand Down
25 changes: 14 additions & 11 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
ext.args = Additional arguments appended to command in module.
ext.args2 = Second set of arguments appended to command in module (multi-tool modules).
ext.args3 = Third set of arguments appended to command in module (multi-tool modules).
ext.suffix = File name ext.suffix output files.
ext.suffix = File name ext.suffix output files. Not available for nf-core modules
ext.prefix = File name ext.prefix output files.
----------------------------------------------------------------------------------------
*/

Expand Down Expand Up @@ -126,6 +127,8 @@ process {
ext.args = { meta.status == 1 ? '-K 100000000 -M -B 3' : '-K 100000000 -M' }
ext.args2 = 'sort'
publishDir = [ enabled: false ]
ext.prefix = { params.split_fastq > 1 ? "${meta.id}".concat(reads.get(0).name.findAll(/part_([0-9]+)?/).last().concat('.')) : "${meta.id}" }

}

withName: 'INDEX_MAPPING' {
Expand All @@ -141,7 +144,7 @@ process {
}

withName: 'SEQKIT_SPLIT2' {
ext.args = "--by-size ${params.split_fastq}"
ext.args = { "--by-size ${params.split_fastq}" }
publishDir = [ enabled: false ]
}
}
Expand Down Expand Up @@ -334,17 +337,17 @@ process {

withName: 'ENSEMBLVEP' {
ext.args = '--everything --filter_common --per_gene --total_length --offline'
ext.container_tag = { "104.3.${params.genome}" }
container = { "nfcore/vep:104.3.${params.genome}" }
publishDir = [ enabled: false ]
}

withName: 'SNPEFF' {
ext.args = '-nodownload -canon -v'
ext.container_tag = { "5.0.${params.genome}" }
container = { "nfcore/snpeff:5.0.${params.genome}" }
publishDir = [ enabled: false ]
}

withName: 'BGZIPTABIX_ANNOTATE' {
withName: 'ANNOTATION_BGZIPTABIX' {
publishDir = [
path: { "${params.outdir}/annotation/${meta.id}" },
enabled: true,
Expand All @@ -356,24 +359,24 @@ process {

if ((params.tools) && (params.tools.contains('snpeff') || params.tools.contains('merge'))) {
process {
withName: 'NFCORE_SAREK:SAREK:ANNOTATE:SNPEFF_ANNOTATE:BGZIPTABIX_ANNOTATE' {
ext.suffix = '_snpEff.ann.vcf'
withName: 'NFCORE_SAREK:SAREK:ANNOTATE:ANNOTATION_SNPEFF:ANNOTATION_BGZIPTABIX' {
ext.prefix = {"${meta.id}_snpEff.ann.vcf"}
}
}
}

if ((params.tools) && (params.tools.contains('vep'))) {
process {
withName: 'NFCORE_SAREK:SAREK:ANNOTATE:ENSEMBLVEP_ANNOTATE:BGZIPTABIX_ANNOTATE' {
ext.suffix = '_VEP.ann.vcf'
withName: 'NFCORE_SAREK:SAREK:ANNOTATE:ANNOTATION_ENSEMBLVEP:ANNOTATION_BGZIPTABIX' {
ext.prefix = {"${meta.id}_VEP.ann.vcf"}
}
}
}

if ((params.tools) && (params.tools.contains('merge'))) {
process {
withName: 'NFCORE_SAREK:SAREK:ANNOTATE:MERGE_ANNOTATE:BGZIPTABIX_ANNOTATE' {
ext.suffix = '_snpEff_VEP.ann.vcf'
withName: 'NFCORE_SAREK:SAREK:ANNOTATE:MERGE_ANNOTATE:ANNOTATION_BGZIPTABIX' {
ext.prefix = {"${meta.id}_snpEff_VEP.ann.vcf"}
}
}
}
Expand Down
9 changes: 8 additions & 1 deletion conf/test.config
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ profiles {
params.skip_markduplicates = true
}
split_fastq {
params.split_fastq = 2
params.split_fastq = 1500
}
targeted {
params.target_bed = 'https://raw.githubusercontent.com/nf-core/test-datasets/sarek/testdata/target.bed'
Expand Down Expand Up @@ -104,4 +104,11 @@ process {
withName:ENSEMBLVEP {
maxForks = 1
}
withName:SEQKIT_SPLIT2{
publishDir = [
path: { "${params.outdir}/${task.process.tokenize(':')[-1].tokenize('_')[0].toLowerCase()}" },
mode: 'copy',
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}
}
26 changes: 13 additions & 13 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,31 +13,31 @@
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
},
"ensemblvep": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "3b366c7c6aac446c1a4ea7c2016092344633b2ec"
},
"fastqc": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "9d0cad583b9a71a6509b754fdf589cbfbed08961"
},
"freebayes": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "9d0cad583b9a71a6509b754fdf589cbfbed08961"
},
"gatk4/createsequencedictionary": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
},
"manta/germline": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "9d0cad583b9a71a6509b754fdf589cbfbed08961"
},
"manta/somatic": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "9d0cad583b9a71a6509b754fdf589cbfbed08961"
},
"manta/tumoronly": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "9d0cad583b9a71a6509b754fdf589cbfbed08961"
},
"multiqc": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
},
"samtools/faidx": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "e0aa89141ffecb5f54d230f7ea46de242b74e084"
},
"samtools/merge": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
Expand All @@ -46,25 +46,25 @@
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
},
"seqkit/split2": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "7006699ff8e4351e4c95d548de959d4222c7862a"
},
"snpeff": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "3b366c7c6aac446c1a4ea7c2016092344633b2ec"
},
"strelka/germline": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "9d0cad583b9a71a6509b754fdf589cbfbed08961"
},
"strelka/somatic": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "9d0cad583b9a71a6509b754fdf589cbfbed08961"
},
"tabix/bgziptabix": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "e22966ce74340cb671576143e5fdbbd71670cffa"
},
"tabix/tabix": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
},
"trimgalore": {
"git_sha": "20d8250d9f39ddb05dfb437603aaf99b5c0b2b41"
"git_sha": "9d0cad583b9a71a6509b754fdf589cbfbed08961"
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions modules/local/bwa/mem/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ process BWA_MEM {
def split_cpus = Math.floor(task.cpus/2)
def args = task.ext.args ?: ''
def args2 = task.ext.args2 ?: ''
def part = params.split_fastq > 1 ? reads.get(0).name.findAll(/part_([0-9]+)?/).last().concat('.') : ""
def prefix = task.ext.suffix ? "${meta.id}${task.ext.suffix}" : "${meta.id}"
def prefix = task.ext.prefix ?: "${meta.id}"
def read_group = meta.read_group ? "-R ${meta.read_group}" : ""
"""
INDEX=`find -L ./ -name "*.amb" | sed 's/.amb//'`
Expand Down
3 changes: 1 addition & 2 deletions modules/local/bwamem2/mem/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ process BWAMEM2_MEM {
def split_cpus = Math.floor(task.cpus/2)
def args = task.ext.args ?: ''
def args2 = task.ext.args2 ?: ''
def part = params.split_fastq > 1 ? reads.get(0).name.findAll(/part_([0-9]+)?/).last().concat('.') : ""
def prefix = task.ext.suffix ? "${meta.id}${task.ext.suffix}" : "${meta.id}"
def prefix = task.ext.prefix ?: "${meta.id}"
def read_group = meta.read_group ? "-R ${meta.read_group}" : ""
"""
INDEX=`find -L ./ -name "*.amb" | sed 's/.amb//'`
Expand Down
30 changes: 0 additions & 30 deletions modules/local/tabix/bgziptabix/main.nf

This file was deleted.

45 changes: 0 additions & 45 deletions modules/local/tabix/bgziptabix/meta.yml

This file was deleted.

13 changes: 7 additions & 6 deletions modules/nf-core/modules/ensemblvep/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/nf-core/modules/fastqc/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/nf-core/modules/freebayes/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/nf-core/modules/manta/germline/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/nf-core/modules/manta/somatic/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/nf-core/modules/manta/tumoronly/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions modules/nf-core/modules/samtools/faidx/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions modules/nf-core/modules/samtools/faidx/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading