Skip to content

fix: lint#468

Merged
FriederikeHanssen merged 4 commits intonf-core:devfrom
maxulysse:dev_lint
Dec 14, 2021
Merged

fix: lint#468
FriederikeHanssen merged 4 commits intonf-core:devfrom
maxulysse:dev_lint

Conversation

@maxulysse
Copy link
Copy Markdown
Member

@maxulysse maxulysse commented Dec 10, 2021

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 10, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 82455b2

+| ✅ 135 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   5 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: assets/multiqc_config.yaml

✅ Tests passed:

Run details

  • nf-core/tools version 2.2.dev0
  • Run at 2021-12-13 15:39:35

FriederikeHanssen
FriederikeHanssen reviewed Dec 10, 2021
View reviewed changes
Comment thread nextflow.config Outdated
FriederikeHanssen
FriederikeHanssen reviewed Dec 13, 2021
View reviewed changes
Comment thread nextflow.config
FriederikeHanssen
FriederikeHanssen reviewed Dec 14, 2021
View reviewed changes
Comment thread nextflow_schema.json
@@ -309,7 +309,7 @@
},
Copy link
Copy Markdown
Contributor

@FriederikeHanssen FriederikeHanssen Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other params don't need to be updated here?

Copy link
Copy Markdown
Member Author

@maxulysse maxulysse Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, all others were good already because of the json schema

Copy link
Copy Markdown
Member Author

@maxulysse maxulysse Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issues where in the nextflow.config

FriederikeHanssen
FriederikeHanssen approved these changes Dec 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@FriederikeHanssen FriederikeHanssen merged commit 5773cc9 into nf-core:dev Dec 14, 2021
@maxulysse maxulysse deleted the dev_lint branch December 14, 2021 12:32
@maxulysse maxulysse mentioned this pull request Dec 14, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @FriederikeHanssen
⚡