modules config update - preprocessing refactor#485
Conversation
| dbsnp = params.dbsnp ? Channel.fromPath(params.dbsnp).collect() : Channel.empty() | ||
| fasta = params.fasta ? Channel.fromPath(params.fasta).collect() : [] | ||
| germline_resource = params.germline_resource ? Channel.fromPath(params.germline_resource).collect() : [] | ||
| germline_resource = params.germline_resource ? Channel.fromPath(params.germline_resource).collect() : Channel.empty() |
There was a problem hiding this comment.
What is the difference again using [] and Channel.empty() ?
There was a problem hiding this comment.
not sure, but it wasn't working
There was a problem hiding this comment.
When creating a process input set, using Channel.empty() won't trigger the process to run, but if you give it [], the process runs with [] as the value for the corresponding parameter.
That's why channel.ifEmpty([]) is used so much for MULTIQC.
… + skip_markduplicates + skip_bqsr) into skip_tools
Co-authored-by: FriederikeHanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
maxulysse
changed the title
|
Stopping the refactoring here not to have a PR so huge it's a black hole that will swallow all the code reviewers |
FriederikeHanssen
left a comment
FriederikeHanssen
left a comment
There was a problem hiding this comment.
looks good to me, not sure why the CI tests are not passing. only the variant_calling one should fail.
OK, I'll figure out the rest of the CI and then call it a day |
Co-authored-by: FriederikeHanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
| } | ||
|
|
||
| //This is apparently useless as it won't overwrite things in the modules.config | ||
| process { |
There was a problem hiding this comment.
Think we can delete this now, no?
There was a problem hiding this comment.
Why not, we still want to test this no?
There was a problem hiding this comment.
it doesn't get overwritten but will need to be moved to the modules.config and activated somehow on test
|
Only gatkspark test falling (on top on the previously variant calling too), but can't manage to make it work on my computer, and figure the current dev is actually not running gatk spark... |
Markdown linting is failingTo keep the code consistent with lots of contributors, we run automated code consistency checks.
Once you push these changes the test should pass, and you can hide this comment 👍 We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help! Thanks again for your contribution! |
3 participants
params.publish_dir_mode--skip_qc,--skip_markduplicatesand--skip_bqsrinto--skip_toolsext.whenfor modules in all current subworkflowsannotate.nfbam2fastq.nfgermline_variant_calling.nfmapping_csv.nfmarkduplicates_csv.nfpair_copy_number_calling.nfpair_variant_calling.nfprepare_genome.nfprepare_intervals.nfprepare_recalibration_csv.nfrecalibrate_csv.nfsplit_fastq.nftumor_variant_calling.nffastqc_trimgalore.nfmarkduplicates.nfprepare_recalibration.nfrecalibrate.nfannotation_ensemblvep/main.nfannotation_snpeff/main.nffgbio_create_umi_consensus/main.nfgatk4_mapping/main.nfgatk_tumor_normal_somatic_variant_calling/main.nfgatk_tumor_only_somatic_variant_calling/main.nfjoint_germline_variant_calling/main.nf