Skip to content

Refactor variant calling#487

Merged
FriederikeHanssen merged 27 commits intonf-core:devfrom
maxulysse:dev_variantcalling
Feb 25, 2022
Merged

Refactor variant calling#487
FriederikeHanssen merged 27 commits intonf-core:devfrom
maxulysse:dev_variantcalling

Conversation

@maxulysse
Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse
Copy link
Copy Markdown
Member Author

Issues with the CI was due to some remnants of suffix syntax.
I'm happy with merging at this state, and I'll make more PR(s) for the rest of the VC/Annotation

Comment thread conf/modules.config
Comment thread subworkflows/local/germline_variant_calling.nf Outdated
Comment thread conf/modules.config
@maxulysse
Copy link
Copy Markdown
Member Author

So just need to take care of Freebayes tests.
But I think this might a a bigger issue, so let's do this in another issue

Copy link
Copy Markdown
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@FriederikeHanssen FriederikeHanssen merged commit a054184 into nf-core:dev Feb 25, 2022
@github-actions
Copy link
Copy Markdown

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --fix
    • Manually resolve anything left from markdownlint .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@maxulysse maxulysse deleted the dev_variantcalling branch February 28, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants