Skip to content

Add dragmap#514

Merged
maxulysse merged 12 commits intonf-core:devfrom
maxulysse:dev_dragmap
Mar 25, 2022
Merged

Add dragmap#514
maxulysse merged 12 commits intonf-core:devfrom
maxulysse:dev_dragmap

Conversation

@maxulysse
Copy link
Copy Markdown
Member

Continue and replace #464 by @emiller88

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen
Copy link
Copy Markdown
Contributor

❤️ @emiller88 and @maxulysse only thing I see missing is adding Dragmap to the Citations, but I think we are way behind there anyways. Can update it at the very end

@maxulysse maxulysse merged commit 7f8c3b0 into nf-core:dev Mar 25, 2022
@maxulysse maxulysse deleted the dev_dragmap branch March 25, 2022 10:59
Comment thread conf/modules.config
}

withName: 'DRAGMAP_HASHTABLE' {
ext.when = { !params.bwa && params.step == "mapping" && params.aligner == "dragmap" }
Copy link
Copy Markdown
Contributor

@edmundmiller edmundmiller Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, I see how the when get's used now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants