Skip to content

Add vqsr subworkflow Work In Progress#546

Closed
GCJMackenzie wants to merge 2 commits intonf-core:devfrom
GCJMackenzie:add_vqsr_subworkflow
Closed

Add vqsr subworkflow Work In Progress#546
GCJMackenzie wants to merge 2 commits intonf-core:devfrom
GCJMackenzie:add_vqsr_subworkflow

Conversation

@GCJMackenzie
Copy link
Copy Markdown

@GCJMackenzie GCJMackenzie commented May 13, 2022

PR checklist

  • This comment contains a description of changes (with reason). Adds the variant quality score recalibrator subworkflow, used for recalibrating joint germline variant calls. Whilst the code is functional with in Atholl, there is some work to do to bring it in line with Sarek guidelines. It is not ready for review currently. Adding PR now for tracking purposes. Linked to issue Do VQSR for HaplotypeCaller calls #89
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@GCJMackenzie GCJMackenzie added enhancement New feature or request gatk labels May 13, 2022
@GCJMackenzie GCJMackenzie requested a review from maxulysse as a code owner May 13, 2022 13:46
@GCJMackenzie GCJMackenzie self-assigned this May 13, 2022
@github-actions
Copy link
Copy Markdown

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @GCJMackenzie,

It looks like this pull-request is has been made against the GCJMackenzie/sarek master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the GCJMackenzie/sarek dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@GCJMackenzie GCJMackenzie changed the title Add vqsr subworkflow Add vqsr subworkflow Work In Progress May 13, 2022
@GCJMackenzie GCJMackenzie changed the base branch from master to dev May 13, 2022 13:50
@maxulysse maxulysse marked this pull request as draft June 2, 2022 09:03
@maxulysse
Copy link
Copy Markdown
Member

I marked this as a draft as it's a WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants