Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b7c2ae4
Still struggling with pair VC tiddit
WackerO Jun 22, 2022
58f9e6c
Merge branch 'dev' of https://github.com/nf-core/sarek into tidditpair
WackerO Jun 22, 2022
41816ac
heeelp D:
WackerO Jun 22, 2022
dd8a25e
Whyyyyyy does nothing work?
WackerO Jun 22, 2022
a875037
pairVC tiddit seems to work now, also sorted input
WackerO Jun 23, 2022
7ec6abc
Fix modules.config and merge branch 'tiddit' into tidditpair
WackerO Jun 23, 2022
adcf1a0
Merge branch 'dev' of https://github.com/nf-core/sarek into tidditpair
WackerO Jun 23, 2022
34c7bb6
Undid two accidental changes
WackerO Jun 23, 2022
40adca1
Added empty tiddit channel, removed unnecessary empty mpileup channel
WackerO Jun 24, 2022
1f417c9
Merge branch 'dev' of https://github.com/nf-core/sarek into tidditpair
WackerO Jun 24, 2022
a1a634a
Update subworkflows/local/pair_variant_calling.nf
WackerO Jun 24, 2022
eee0ebb
Update subworkflows/local/pair_variant_calling.nf
WackerO Jun 24, 2022
5d3d00f
Update subworkflows/local/pair_variant_calling.nf
WackerO Jun 24, 2022
e6b0dcd
SVDB is published, removed unnecessary file, some cleanup
WackerO Jun 24, 2022
4225425
Merge branch 'dev' of https://github.com/nf-core/sarek into tidditpair
WackerO Jun 24, 2022
31c55ae
bugfix
WackerO Jun 24, 2022
3f0c668
linting
WackerO Jun 24, 2022
9923ab5
Update subworkflows/local/pair_variant_calling.nf
WackerO Jun 24, 2022
bea39d0
Everything seems to work now
WackerO Jun 27, 2022
e9ef892
Merge branch 'tidditpair' of https://github.com/WackerO/sarek into ti…
WackerO Jun 27, 2022
1475991
Merge branch 'dev' of https://github.com/nf-core/sarek into tidditpair
WackerO Jun 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#576](https://github.com/nf-core/sarek/pull/576) - Add modules and subworkflows for `cnvkit` germline mode
- [#582](https://github.com/nf-core/sarek/pull/582) - Added option `--vep_out_format` for setting the format of the output-file from VEP to `json`, `tab` or `vcf` (default)
- [#594](https://github.com/nf-core/sarek/pull/594) - Add parameter `--save_output_as_bam` to allow output of result files in BAM format
- [#600](https://github.com/nf-core/sarek/pull/600) - Added description for UMI related params in schema
- [#597](https://github.com/nf-core/sarek/pull/597) - Added tiddit for tumor variant calling
- [#600](https://github.com/nf-core/sarek/pull/600) - Added description for UMI related params in schema

### Changed

Expand Down
18 changes: 18 additions & 0 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -1076,6 +1076,24 @@ process{
ext.prefix = {"${meta.id}.somatic_snvs"}
}

//TIDDIT
withName: 'NFCORE_SAREK:SAREK:PAIR_VARIANT_CALLING:RUN_TIDDIT_NORMAL:TABIX_BGZIP_TIDDIT_SV' {
ext.prefix = {"${meta.id}.normal.vcf"}
}

withName: 'NFCORE_SAREK:SAREK:PAIR_VARIANT_CALLING:RUN_TIDDIT_TUMOR:TABIX_BGZIP_TIDDIT_SV' {
ext.prefix = {"${meta.id}.tumor.vcf"}
}

Comment thread
WackerO marked this conversation as resolved.
//SVDB
withName: 'NFCORE_SAREK:SAREK:PAIR_VARIANT_CALLING:SVDB_MERGE' {
publishDir = [
mode: params.publish_dir_mode,
path: { "${params.outdir}/variant_calling/${meta.id}/tiddit" },
pattern: "*vcf"
]
}

// VCF QC
withName: 'BCFTOOLS_STATS'{
ext.when = { !(params.skip_tools && params.skip_tools.contains('bcftools')) }
Expand Down
3 changes: 3 additions & 0 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,9 @@
"strelka/somatic": {
"git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d"
},
"svdb/merge": {
"git_sha": "313d76e00525c8e975dabce0c34973fd53c3f4dd"
},
"tabix/bgziptabix": {
"git_sha": "49b18b1639f4f7104187058866a8fab33332bdfe"
},
Expand Down
57 changes: 57 additions & 0 deletions modules/nf-core/modules/svdb/merge/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions modules/nf-core/modules/svdb/merge/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion subworkflows/local/germline_variant_calling.nf
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ workflow GERMLINE_VARIANT_CALLING {
manta_vcf = Channel.empty()
strelka_vcf = Channel.empty()
tiddit_vcf = Channel.empty()
mpileup = Channel.empty()
Comment thread
WackerO marked this conversation as resolved.

// Remap channel with intervals
cram_recalibrated_intervals = cram_recalibrated.combine(intervals)
Expand Down
40 changes: 33 additions & 7 deletions subworkflows/local/pair_variant_calling.nf
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,30 @@ include { RUN_STRELKA_SOMATIC } from '../nf-core/variantca
include { RUN_CNVKIT_SOMATIC } from '../nf-core/variantcalling/cnvkit/somatic/main.nf'
include { RUN_MPILEUP as RUN_MPILEUP_NORMAL } from '../nf-core/variantcalling/mpileup/main'
include { RUN_MPILEUP as RUN_MPILEUP_TUMOR } from '../nf-core/variantcalling/mpileup/main'
include { RUN_TIDDIT as RUN_TIDDIT_NORMAL } from '../nf-core/variantcalling/tiddit/main.nf'
include { RUN_TIDDIT as RUN_TIDDIT_TUMOR } from '../nf-core/variantcalling/tiddit/main.nf'
include { SVDB_MERGE } from '../../modules/nf-core/modules/svdb/merge/main.nf'

workflow PAIR_VARIANT_CALLING {
take:
tools // Mandatory, list of tools to apply
cram_pair // channel: [mandatory] cram
bwa // channel: [optional] bwa
chr_files
dbsnp // channel: [mandatory] dbsnp
dbsnp_tbi // channel: [mandatory] dbsnp_tbi
dict // channel: [mandatory] dict
fasta // channel: [mandatory] fasta
fasta_fai // channel: [mandatory] fasta_fai
germline_resource // channel: [optional] germline_resource
germline_resource_tbi // channel: [optional] germline_resource_tbi
intervals // channel: [mandatory] intervals/target regions
intervals_bed_gz_tbi // channel: [mandatory] intervals/target regions index zipped and indexed
intervals_bed_combined // channel: [mandatory] intervals/target regions in one file unzipped
mappability
msisensorpro_scan // channel: [optional] msisensorpro_scan
germline_resource // channel: [optional] germline_resource
germline_resource_tbi // channel: [optional] germline_resource_tbi
panel_of_normals // channel: [optional] panel_of_normals
panel_of_normals_tbi // channel: [optional] panel_of_normals_tbi
chr_files
mappability

main:

Expand All @@ -41,6 +45,7 @@ workflow PAIR_VARIANT_CALLING {
strelka_vcf = Channel.empty()
msisensorpro_output = Channel.empty()
mutect2_vcf = Channel.empty()
tiddit_vcf = Channel.empty()

// Remap channel with intervals
cram_pair_intervals = cram_pair.combine(intervals)
Expand Down Expand Up @@ -157,7 +162,7 @@ workflow PAIR_VARIANT_CALLING {
fasta,
fasta_fai)

strelka_vcf = Channel.empty().mix(RUN_STRELKA_SOMATIC.out.strelka_vcf)
strelka_vcf = Channel.empty().mix(RUN_STRELKA_SOMATIC.out.strelka_vcf)
ch_versions = ch_versions.mix(RUN_STRELKA_SOMATIC.out.versions)
}

Expand Down Expand Up @@ -188,14 +193,35 @@ workflow PAIR_VARIANT_CALLING {
ch_versions = ch_versions.mix(GATK_TUMOR_NORMAL_SOMATIC_VARIANT_CALLING.out.versions)
}

// if (tools.contains('tiddit')) {
// }
//TIDDIT
if (tools.contains('tiddit')){
cram_normal = cram_pair.map{meta, normal_cram, normal_crai, tumor_cram, tumor_crai ->
[meta, normal_cram, normal_crai]
}
cram_tumor = cram_pair.map{meta, normal_cram, normal_crai, tumor_cram, tumor_crai ->
[meta, tumor_cram, tumor_crai]
}

RUN_TIDDIT_NORMAL(cram_normal, fasta, bwa)
Comment thread
WackerO marked this conversation as resolved.
RUN_TIDDIT_TUMOR(cram_tumor, fasta, bwa)
SVDB_MERGE(RUN_TIDDIT_NORMAL.out.tiddit_vcf.join(RUN_TIDDIT_TUMOR.out.tiddit_vcf)
.map{meta, vcf_normal, vcf_tumor ->
[meta, [vcf_normal, vcf_tumor]]
}, false)
tiddit_vcf = SVDB_MERGE.out.vcf

ch_versions = ch_versions.mix(RUN_TIDDIT_NORMAL.out.versions)
Comment thread
WackerO marked this conversation as resolved.
ch_versions = ch_versions.mix(RUN_TIDDIT_TUMOR.out.versions)
ch_versions = ch_versions.mix(SVDB_MERGE.out.versions)
}

emit:
freebayes_vcf
manta_vcf
msisensorpro_output
mutect2_vcf
strelka_vcf
tiddit_vcf

versions = ch_versions
}
1 change: 0 additions & 1 deletion subworkflows/nf-core/variantcalling/tiddit/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions tests/test_tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,23 @@
- path: results/variant_calling/sample1/cnvkit/test.paired_end.recalibrated.sorted.cns
- path: results/variant_calling/sample1/cnvkit/test.paired_end.recalibrated.sorted.call.cns

- name: Run variant calling on somatic sample with tiddit
command: nextflow run main.nf -profile test,tools_somatic,docker --tools tiddit -c ./tests/nextflow.config
tags:
- tiddit
- somatic
- variant_calling
files:
- path: results/variant_calling/sample3/tiddit/sample3.ploidies.tab
- path: results/variant_calling/sample3/tiddit/sample3.vcf.gz
- path: results/variant_calling/sample3/tiddit/sample3.vcf.gz.tbi
- path: results/variant_calling/sample4_vs_sample3/tiddit/sample4_vs_sample3.normal.vcf.gz
- path: results/variant_calling/sample4_vs_sample3/tiddit/sample4_vs_sample3.normal.vcf.gz.tbi
- path: results/variant_calling/sample4_vs_sample3/tiddit/sample4_vs_sample3.tumor.vcf.gz
- path: results/variant_calling/sample4_vs_sample3/tiddit/sample4_vs_sample3.tumor.vcf.gz.tbi
- path: results/variant_calling/sample4_vs_sample3/tiddit/sample4_vs_sample3_sv_merge.vcf
- path: results/variant_calling/sample4_vs_sample3/tiddit/sample4_vs_sample3.ploidies.tab

- name: Run variant calling on germline sample with tiddit
command: nextflow run main.nf -profile test,tools_germline,docker --tools tiddit -c ./tests/nextflow.config
tags:
Expand Down
12 changes: 7 additions & 5 deletions workflows/sarek.nf
Original file line number Diff line number Diff line change
Expand Up @@ -833,21 +833,22 @@ workflow SAREK {
PAIR_VARIANT_CALLING(
params.tools,
cram_variant_calling_pair,
[],
chr_files,
dbsnp,
dbsnp_tbi,
dict,
fasta,
fasta_fai,
germline_resource,
germline_resource_tbi,
intervals,
intervals_bed_gz_tbi,
intervals_bed_combined,
mappability,
msisensorpro_scan,
germline_resource,
germline_resource_tbi,
pon,
pon_tbi,
chr_files,
mappability
pon_tbi
)

// Gather vcf files for annotation and QC
Expand All @@ -866,6 +867,7 @@ workflow SAREK {
vcf_to_annotate = vcf_to_annotate.mix(PAIR_VARIANT_CALLING.out.mutect2_vcf)
vcf_to_annotate = vcf_to_annotate.mix(PAIR_VARIANT_CALLING.out.manta_vcf)
vcf_to_annotate = vcf_to_annotate.mix(PAIR_VARIANT_CALLING.out.strelka_vcf)
vcf_to_annotate = vcf_to_annotate.mix(PAIR_VARIANT_CALLING.out.tiddit_vcf)

// Gather used softwares versions
ch_versions = ch_versions.mix(GERMLINE_VARIANT_CALLING.out.versions)
Expand Down